-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Physics Shield and Closed Solid Field #776
Add Physics Shield and Closed Solid Field #776
Conversation
Pre - Release 21
Extra Fizzlers
Revert "Extra Fizzlers"
Is this going to be merged into the Dev branch? |
There's a couple things first:
|
Felix Griffin didn't even call it a Physler. |
Update Physics Shield Description
To-do List:
|
"Nodraw" "BEE2/fizz/fourthreaper/player_clip_electric" | ||
"Keys" | ||
{ | ||
"classname" "func_clip_vphysics" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clips, make it just use tools/toolstrigger
, and remove solidity
/solidbsp
/spawnflags
- those aren't used for func_clip_vphysics
. player_clip_electric
is only useful for player clips.
It still works. |
It does, but removing those means you don't need to pack that material. |
50s variant of Closed Solid Field added. Will this be merged into dev? |
I'll want to do a quick lookover first, but yes. |
Is it going to be merged? |
The Physics Shield should block portals as an enhancement, and to make it look more like a fizzler. |
No, the item is explicitly supposed to not block portal shots. Play this map. |
People might not like the fact that you can shoot through it. And I have played that map. It will improve maps if you can't shoot through it. |
No, it will make that map impossible to make. If it blocks portal shots, it's not a Physler anymore. |
I'll still need to be collaborator in order to update these items. |
Not really, you can create a separated new branch using your github app containing your addon, thats what i did with my Cold Light Strip addon. I didn´t use this pull request system at all..... |
@LautaroL20 You need to be collaborator to do that. |
Did u even tried to send a small commit trhough ghitub to see if it works for you? |
It doesn't work. |
:( |
@LautaroL20 Can you atleast merge |
Well, first ill need to ask Spencer who is the own of this Beemod version, if hes agree be sure ill merge it into dev. |
@TheDarkBomber - This is the fist time i tested your addon, and i saw there are a couple of things ill want to report to your repository section. |
Ok. Report them. |
Don't merge things to |
@TeamSpen210 Re-add me as collaborator so I can update these items. |
@TheDarkBomber - You don't need to be a collaborator, just update them on your contribution repository and @TeamSpen210 will merge them when finished. |
@TheDarkBomber - You should finish these so they can be merged. |
This makes the Closed Solid Field ready for release. (BEEmod#776)
Ok, I have finished the Closed Solid Field with the P1 variant, so it is ready for release, but I need to now add the Overgrown PRF. Also, it says there are conflicts, but this PR uses different branches. After I create the Overgrown PRF, this PR can be closed, and my |
The Physics Repulsion Field has now been completed and is ready for release. (BEEmod#776)
Overgrown PRF added! These items are now ready for release! :) |
Will be implemented for next release. :) Pull Request Closed! |
Finally! Now it's time to get to work on the Blue Portals Pack! |
@Luke18033 The PR for the BP pack will not be opened right away, though. It will be opened when it is ready. |
Open it once you have something, so we can comment on it whenever. |
Ok. I have the music made by @Byzarru. |
Should the branch for this be deleted now that the items are in |
Reverts #772
Even though the fizzlers are not perfect, they CAN be updated in the FUTURE. Realise that before you revert a pull request.
(Physics Shield name debated)